[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by tomauger):

 Replying to [comment:120 jorbin]:
 Thanks for this input.

 > > 1. .ICO or not?
 > I think we need to.  The library is a mess though and I think including
 it as-is is a bad idea.  I would rather not include this in the release
 then include that library right now.
 So basically scavenge and build our own. I'm good with that.


 > > 2. _media_states(). Looking for a little guidance on that one.
 > We should include it in that function so that the image is properly
 marked as the favicon.
 Hmmm. Still looking for more info on this one.


 > > 3. Should we delete the original image after cropping?
 > My first thought is that we should treat it the same way as an image
 uploaded for the custom background and custom header.
 Okay, sounds good.


 > > 4. Thickbox or not for the crop UI?
 > I think an iframe inline is going to be the best approach.
 Okay.


 > > 5. Location of the actual favicon field in Settings > General (see my
 comments on why it's currently on top). If we're not putting it on top (or
 bottom) then I'm looking for some creative suggestions to how to shim it
 into the page within the current form.
 > Not sure on this one.
 I'ma keep it at the top for now, then.

 > Overall, I think we might be best developing this as a plugin that we
 can then bring in early in 3.5 rather then trying to force this into 3.4.
 My feeling is that if we can't get the ICO library into this cycle, then
 we still release for 3.4, but only with a .ico upload passthrough option
 (no crop, only .ico files permitted). This will work across all browsers
 and will set the stage for something better in 3.5.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:121>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software