[wp-trac] [WordPress Trac] #20187: PemFTP Failing to Fall Back to Pure PHP Implementation

[WordPress Trac]

#20187: PemFTP Failing to Fall Back to Pure PHP Implementation
------------------------------------+------------------------------
 Reporter:  merty                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  External Libraries      |     Version:  2.3.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------------------

Comment (by dd32):

 > . If the functionality of loading modules is not available or has been
 disabled (either by setting enable_dl off or by enabling safe mode in
 php.ini) an E_ERROR is emitted and execution is stopped. If dl() fails
 because the specified library couldn't be loaded, in addition to FALSE an
 E_WARNING message is emitted.

 [http://au2.php.net/dl This] makes it sound like the Execution is halted
 if loading modules is disabled.. which doesn't sound right to me.. btu
 failing with a true-ey value when it's disabled doesn't sound right
 either..

 As for the code in PemFTP, as it's an external library, anything here
 should also be raised as a ticket/issue for the library - although i seem
 to recall that development of PemFTP doesn't have any active tracker.

 As for the code here in WordPress, I'm all for changing to making sure
 it's callable, and checking capabilities rather than the result of dl().
 although, I think we should keep to using extension_loaded() as in the if
 block that surounds that code, rather than function_exists().

 For reference, I believe this is the only location in WordPress that we
 actually try using dl(), We don't do similar things for MySQL or GD
 (although, they'd benefit more than FTP would from it's usage).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20187#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software