[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

WordPress Trac wp-trac at lists.automattic.com
Mon Mar 5 19:36:33 UTC 2012


#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by TomAuger):

 Replying to [comment:111 azaozz]:
 > Yeah, 300x300 or 350x350 seems large enough. The idea is to insert an
 iframe after uploading the image instead of using thickbox. The iframe
 would be pretty much the same as in TB but will be placed directly in the
 page rather than inserted at the bottom and shown with position:fixed in
 the middle or the screen. To make this work there can be a hidden iframe
 under the upload field with some basic JS that will
 `$('iframe').slideDown('fast')` when something is loaded there, and of
 course `$('iframe').slideUp('fast')` when not needed any more.

 Sounds good. But why create some custom JS UI components that would be
 unique to this feature, rather than leveraging Thickbox, that is used by
 the MediaCenter and other core features? I guess I just don't understand
 the need to roll our own here, when there's something perfectly workable.

 Sorry, can you clarify that?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:118>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list