[wp-trac] [WordPress Trac] #19978: Twenty Twelve

[WordPress Trac]

#19978: Twenty Twelve
----------------------------+-----------------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  Future Release
Component:  Bundled Theme   |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+-----------------------------
Changes (by dimadin):

 * cc: forumi@… (added)


Comment:

 Replying to [comment:31 lancewillett]:
 > In [20007]:
 > {{{
 > #!CommitTicketReference repository="" revision="20007"
 > Twenty Twelve: add support for toggling the navigation menu in small
 screens. See #19978
 > }}}

 navigation.js is enqueued in the wrong way. There is no need for
 wp_enqueue_script( 'jquery' ), and $deps argument in wp_enqueue_script()
 should be array, not string. Attached patch fixes this.

 twentytwelve_scripts() should be called later so that jQuery is loaded in
 footer too (if it's not called earlier by some plugin). Also,
 navigation.js could get minification.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19978#comment:56>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software