[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by azaozz):

 Replying to [comment:109 TomAuger]:
 > Okay, I'll revise the front-end filter for now to only accept PNG and
 JPG, and make sure the error message reflects that.

 Perhaps it would be better to let the users add `favicon.ico` files
 (matching the entire file name) instead of banning uploads of `.ico`
 files.

 In general letting the user upload an image, then crop it and set it as a
 favicon implies expectations that it would work. However that won't work
 in 30%-90% of the browsers (IE), depending on the region. Also if the
 users are in IE, the favicon won't show even for them.

 Thinking the best UX here would be to include some help/explanation in the
 screen help tabs directing the users to upload ready-made favicon.ico
 files. Anything else would result in a lot of:
 {{{
 HELP! WP is broken, I uploaded image to show in the browser tab
 but it's not working...
 }}}

 > I'm happy to put it anywhere, however, the rationale for its position is
 twofold...
 > I'll defer that decision until I get more feedback on the matter.

 Sounds good. Yes, the favicon is somewhat connected to the site name
 (identity) but is not "more important" than the name. Perhaps it would be
 better placed under the site name, tagline and address fields.

 > The only issue I can see with this is that the crop UI is really
 (really) large at the moment, though arguably we could make the whole
 thing a bit smaller (though I wouldn't want to go less than 300x300 for
 the image size). So that's a pretty big chunk of real estate to just
 insert smack in the middle of the rest of the Settings > General form.
 Unless I'm not properly understanding your suggestion?

 Yeah, 300x300 or 350x350 seems large enough. The idea is to insert an
 iframe after uploading the image. The iframe would be pretty much the same
 as in thickbox but will be placed directly in the page rather than
 inserted at the bottom and shown with position:fixed in the middle or the
 screen. To make this work there can be a hidden iframe under the upload
 field with some basic JS that will `$('iframe').slideDown('fast')` when
 something is loaded there, and of course `$('iframe').slideUp('fast')`
 when not needed any more. That would make pretty sleek UI :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:111>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software