[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General
WordPress Trac
wp-trac at lists.automattic.com
Thu Mar 1 15:49:00 UTC 2012
#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
Reporter: jane | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 3.4
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing ux-feedback |
-------------------------------------------------+------------------
Comment (by tomAuger):
Replying to [comment:97 ocean90]:
> Just my 2 cents:
thanks for the awesome advice, see below...
>
> - `echo <<<` ... do we really want this?
What's wrong with the heredoc approach? Not that it's THAT many lines of
code, but seems quite readable to me.
> - instead of FAVICON_SIZE I would prefer `apply_filters(
'favicon_size', 32 )`
Right you are. Consider it done.
> - Because the image will be uploaded to the media library, the image
should be marked, see `_media_states()`
> - If I delete the favicon from the media library the options should get
reset accordingly (like for theme mods `_delete_attachment_theme_mod()`)
Both of these sound like best practices. I know nothing about either of
these methods, so I will need to research a bit before committing to
getting them into my next update.
> - And should we delete the original image after cropping?
I don't know the answer to this one. It depends on what the philosophy
behind the Media Library is - do we keep a record of the full-size image
of everything that goes into the library? Or is this a different case and
the original scaled document is a throwaway - all we wanted was the
smaller size?
> - ''favicon-upload.php'' should set a `$title`
Tru dat.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:99>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list