[wp-trac] [WordPress Trac] #21115: Remove ancient wp-settings.php global unsetting code

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 29 20:56:09 UTC 2012


#21115: Remove ancient wp-settings.php global unsetting code
--------------------------+-----------------
 Reporter:  nacin         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.5
Component:  Unit Tests    |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------
 We have this:

 {{{
 // Ensure these global variables do not exist so they do not interfere
 with WordPress.
 unset( $wp_filter, $cache_lastcommentmodified );
 }}}

 It used to include more variables, but they were removed when a few of us
 took an axe to wp-settings.php back in 3.0.

 I suggest we remove both. $cache_lastcommentmodified can easily become a
 static variable within that function (I mean, we're dealing with pre-1.5
 code here) and a lot of things would be broken if people overrode
 WordPress globals prior to startup, not just $wp_filter.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21115>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list