[wp-trac] [WordPress Trac] #21096: Filter on is_front_page return value

WordPress Trac wp-trac at lists.automattic.com
Thu Jun 28 11:30:37 UTC 2012


#21096: Filter on is_front_page return value
--------------------------+------------------------------
 Reporter:  CoenJacobs    |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------------------
Changes (by CoenJacobs):

 * keywords:  dev-feedback has-patch => dev-feedback


Comment:

 Replying to [comment:1 scribu]:
 > This sounds like a bug in is_front_page(). We should try to fix it,
 instead of papering over it with a filter.
 You are right, that will be better. Think the problem is that the page
 which you set to the front page is no longer a page, but a post type
 archive. Therefore, this '$this->is_page( get_option( 'page_on_front' ) )'
 will never return true, since the current page is no page. So maybe this
 issue is in is_page() instead of this is_front_page() function?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21096#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list