[wp-trac] [WordPress Trac] #20955: get_file_data() is more strict than get_page_templates() was in 3.3

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 25 21:07:09 UTC 2012


#20955: get_file_data() is more strict than get_page_templates() was in 3.3
------------------------------------------+--------------------
 Reporter:  nacin                         |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  3.4.1
Component:  Themes                        |     Version:
 Severity:  major                         |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |
------------------------------------------+--------------------

Comment (by nacin):

 In [21117]:
 {{{
 #!CommitTicketReference repository="" revision="21117"
 Revert detection of page templates to 3.3 functionality.

 WP_Theme in 3.4.0 used get_file_data(), which is far too strict when
 compared to  the original regular expression in get_page_templates().
 This causes missing templates when, for example, the PHP comment
 starts on the same line as the header.

 see #20955 for trunk.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20955#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list