[wp-trac] [WordPress Trac] #21070: Added a filter to the sub-menu class attribute

[WordPress Trac]

#21070: Added a filter to the sub-menu class attribute
-----------------------------------+------------------------------
 Reporter:  bjornjohansen          |       Owner:
     Type:  enhancement            |      Status:  reopened
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Menus                  |     Version:  3.4
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------

Comment (by bjornjohansen):

 Replying to [comment:5 alexvorn2]:
 > need the second opinion? close this! :)

 Could you please elaborate on the reasoning behind this? I believe I have
 provided reasonable arguments for why the patch should be included.

 Yet another argument would be the mere existence of the $depth variable
 itself. We have it in the method, but it's only use is for providing
 white-space padding in the HTML source code. The included patch makes use
 of the variable in another, useful way.

 Others than me have clearly seen the use for this, and because it just
 adds a filter, it is totally unobtrusive.

 Before you close this, please read the recommendation from Google (in the
 link I provided), under the headline: "Use class selectors instead of
 descendant selectors."

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21070#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software