[wp-trac] [WordPress Trac] #18909: Bundled jQuery UI should have CSS

WordPress Trac wp-trac at lists.automattic.com
Sat Jun 23 12:17:25 UTC 2012


#18909: Bundled jQuery UI should have CSS
-----------------------------------+-----------------------------
 Reporter:  helenyhou              |       Owner:
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  Future Release
Component:  UI                     |     Version:  3.3
 Severity:  normal                 |  Resolution:
 Keywords:  ui-feedback has-patch  |
-----------------------------------+-----------------------------

Comment (by markoheijnen):

 Replying to [comment:59 helenyhou]:
 > I wonder that myself, but seeing as most of the admin stylesheets were
 combined not long ago, I don't think we'd split one out again and then
 enqueue it everywhere. If we were to put it into the main stylesheets, the
 maintenance would still be difficult and perhaps more so than having just
 a few elements with more specific selectors defined in other places, as
 colors are in one place and structure in another. It seems that future
 maintenance is a (the?) sticking point here, but still think it's worth
 pursuing.

 So if I understand it right "wp-jquery-ui-dialog" has been combined into
 "editor-buttons"? So that is the reason why it is duplicated now for some
 kind of backwards compatibility?

 The reason why I removed the dialog code from "editor-buttons" in my fork
 is to test it out how it looks without it. And I do like how it looks now.
 That said I'm not a designer ;) You can always duplicate it back to
 "editor-buttons" but thats kind of ugly but I can understand why.

 Btw. I also removed the link color of ".ui-state-default a, .ui-state-
 default a:link, .ui-state-default a:visited". That the same what
 stephenh1988 does. Didn't do it for hover since WordPress already
 overrides that.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18909#comment:62>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list