[wp-trac] [WordPress Trac] #16165: Media Library Bulk Delete: Error in deleting...

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 18 23:16:43 UTC 2012


#16165: Media Library Bulk Delete: Error in deleting...
------------------------------------+-----------------------------
 Reporter:  hakre                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  low                     |   Milestone:  Future Release
Component:  Media                   |     Version:  3.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------------
Changes (by bpetty):

 * cc: bpetty (added)


Comment:

 I have attached an updated patch against latest SVN trunk. Besides
 updating it though, I also made 3 fixes to the old patch.

 1. Added esc_html filter for titles in error messages (required for
 security).
 2. Fixed usage of WP_Error so it doesn't add a blank error first
 incorrectly (when there is at least one error).
 3. The get_post() check actually needed to be negated in order to properly
 skip over items that were in fact deleted already, and also so that bulk
 item deletion actually worked properly (the original patch made it
 impossible to delete items using bulk deletion).

 This patch, like the original, is a fix for both #16165 as well as #16164.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16165#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list