[wp-trac] [WordPress Trac] #21016: Quick Edit removes custom added edit columns on save

[WordPress Trac]

#21016: Quick Edit removes custom added edit columns on save
-----------------------------+----------------------
 Reporter:  sillybean        |       Owner:
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:
Component:  Quick/Bulk Edit  |     Version:  3.3
 Severity:  normal           |  Resolution:  invalid
 Keywords:                   |
-----------------------------+----------------------
Changes (by nacin):

 * status:  new => closed
 * version:  3.4 => 3.3
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 I can reproduce this in 3.3 for your plugin as well.

 The issue is that content_audit_columns() uses `$_GET['post_type']` to
 determine which post type is being requested. This is not set during an
 inline save. `$_REQUEST['post_type']` would work here. There may be
 something better to check; I didn't look.

 You might have found it to work in 3.3 based on your settings, but it does
 not work with the plugin's defaults. By default, only pages are audited.
 But if `$_GET['post_type']` is not set, it will fall back to posts, which
 is by default off. Turning on auditing for posts on the settings screen
 does allow the quick edit to work in 3.4, as it would then use the post
 options.

 A side note, on activation, I get a lot of warnings in my log, because
 there are no options in the DB but there is some code that expects them to
 be present. Things like in_array() failing as it doesn't get an array.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21016#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software