[wp-trac] [WordPress Trac] #18006: Twenty Eleven header.php size uses width instead of height

[WordPress Trac]

#18006: Twenty Eleven header.php size uses width instead of height
---------------------------+------------------------------
 Reporter:  RVoodoo        |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  3.2
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |
---------------------------+------------------------------

Comment (by ericlewis):

 I don't see the logic here either, and infers that
 wp_get_attachment_image_src() requires an extra large height as argument,
 not the actual height.

 Replying to [comment:4 SergeyBiryukov]:
 > Twenty Ten checks if `current_theme_supports( 'post-thumbnails' )`, and
 then calls
 > `wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'post-
 thumbnail' )`, which seems to serve the same purpose, but looks a bit
 cleaner.

 Yep. Replacing the conditional with the version from twentyten would be
 better for code clarity.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18006#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software