[wp-trac] [WordPress Trac] #20921: Customizer should check theme errors(), not just exists()

WordPress Trac wp-trac at lists.automattic.com
Tue Jun 12 18:39:18 UTC 2012


#20921: Customizer should check theme errors(), not just exists()
------------------------------+---------------------
 Reporter:  nacin             |       Owner:  nacin
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  3.4
Component:  Themes            |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by nacin):

 * owner:   => nacin
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [21069]:
 {{{
 #!CommitTicketReference repository="" revision="21069"
 Theme Customizer: Validate themes with more than just an existence check.
  * The current theme goes through validate_current_theme().
  * If doing a preview of a different theme, we check theme->errors().

 Also:
  * Don't attach previewing hooks when previewing the current theme.
 Aside from being unnecessary, this prevents issues with a theme with
 the error of theme_parent_invalid.
  * Call send_origin_headers() earlier, to allow wp_die( '0' ) to properly
 be returned in a domain mapping situation.
  * Fix the 'Save & Activate' message on themes.php.

 fixes #20921.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20921#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list