[wp-trac] [WordPress Trac] #20921: Customizer should check theme errors(), not just exists()

[WordPress Trac]

#20921: Customizer should check theme errors(), not just exists()
------------------------------+------------------
 Reporter:  nacin             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.4
Component:  Themes            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by nacin):

 _save_feedback() is not implemented correctly, which means this string is
 lost to the abyss. Also, if you have a lot of themes, then the code that
 moves div.updated's to below h2's doesn't fire for a while, causing it to
 jump. In some situations (such as when the admin_notices hook isn't used)
 there isn't a good workaround, but in this case, we can simply move that
 code block.

 The diff within the code block won't show up easily, but you can see that
 this was added:
 {{{
 if ( isset( $_GET['previewed'] ) ) { ?>
                 <div id="message2" class="updated"><p><?php printf( __(
 'Settings saved and theme activated. <a href="%s">Visit site</a>.' ),
 home_url( '/' ) ); ?></p></div>
                 <?php } elseif
 }}}

 So much nicer than the "this theme has widgets" string with the comma
 splice.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20921#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software