[wp-trac] [WordPress Trac] #20448: Update Twenty Ten and Twenty Eleven to use 3.4 features
WordPress Trac
wp-trac at lists.automattic.com
Mon Jun 11 21:25:09 UTC 2012
#20448: Update Twenty Ten and Twenty Eleven to use 3.4 features
----------------------------+--------------------------
Reporter: nacin | Owner: koopersmith
Type: task (blessed) | Status: closed
Priority: high | Milestone: 3.4
Component: Bundled Theme | Version: 3.4
Severity: major | Resolution: fixed
Keywords: has-patch |
----------------------------+--------------------------
Changes (by nacin):
* status: reopened => closed
* resolution: => fixed
Comment:
In [21054]:
{{{
#!CommitTicketReference repository="" revision="21054"
Do not specify background-image: none when a user removes a custom
background
on a theme that has a default background image.
The onus is on the theme to omit the default background-image from
style.css,
to allow the user to remove the default background image. Or, the theme
can
specify a background-image for the body selector, as long as they then
zero
it out for body.custom-background, like so:
{{{
body {
background-image: url( ... );
}
body.custom-background {
background-image: none;
}
}}}
This allows the theme to be compatible with the custom background feature
but also gracefully degrade if the background feature is disabled.
This is the same behavior as 3.3; setting a default image has simply been
made more prominent in 3.4. Reverts [21013], also parts of [21001].
see #20448 for change and discussion history.
see #20132, which will now be marked as invalid.
Also, per previous changes in #20448, the custom-background class should
not
be shown when only a default color is in use.
fixes #20448.
}}}
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20448#comment:34>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list