[wp-trac] [WordPress Trac] #20132: Custom Background Image issue

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 11 19:05:59 UTC 2012


#20132: Custom Background Image issue
--------------------------+-----------------------
 Reporter:  nhuja         |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.4
Component:  Themes        |     Version:  3.3.1
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+-----------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 My thoughts on this: http://lists.automattic.com/pipermail/wp-
 testers/2012-June/014495.html

 > With regards to child themes, if a child theme wants to override a
 parent theme's default settings, then they should be doing it via PHP, not
 via CSS. That means either calling add_theme_support() and setting
 default-image to its own value (or to false), or calling
 remove_theme_support().
 >
 > If we make it clear that default background images should *not* be
 specified in CSS, then we can just remove the "background-image: none"
 stuff, and it would allow a child theme to provide a CSS background-image
 as long as the user also presses "Remove Background Image" in Appearance.
 >
 > That would make http://core.trac.wordpress.org/ticket/20132 invalid,
 would simplify some of our logic, would probably be less of a backwards
 compatibility risk, and would avoid stomping on custom CSS (even though
 the child theme should probably be using the API properly).

 And so, I think we should make it clear that default background images are
 not specified in the CSS. Suggesting a partial revert of this. Patch on
 the way.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20132#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list