[wp-trac] [WordPress Trac] #20448: Update Twenty Ten and Twenty Eleven to use 3.4 features
WordPress Trac
wp-trac at lists.automattic.com
Mon Jun 11 08:33:42 UTC 2012
#20448: Update Twenty Ten and Twenty Eleven to use 3.4 features
----------------------------+--------------------------
Reporter: nacin | Owner: koopersmith
Type: task (blessed) | Status: reopened
Priority: high | Milestone: 3.4
Component: Bundled Theme | Version: 3.4
Severity: major | Resolution:
Keywords: has-patch |
----------------------------+--------------------------
Changes (by duck_):
* status: closed => reopened
* resolution: fixed =>
Comment:
There are still some issues with body.custom-background since
get_background_color() will always return true for themes with a
registered default. So, the check should be:
{{{
if ( get_theme_mod( 'background_color' ) || get_theme_mod(
'background_image' ) || get_theme_support( 'custom-background', 'default-
image' ) ) ...
}}}
Problem reported by Frumph: http://lists.automattic.com/pipermail/wp-
testers/2012-June/014487.html
There also seem to be some issues when looking at _custom_background_cb():
* $background includes the default-image, so the default-image check on
line 1112 is redundant
* $background includes the default-image, so the "there is not a
$background, but there is a default" branch will never be reached
It seems like switching $background back to just the saved image would fix
this:
{{{
$background = get_theme_mod( 'background_image' );
}}}
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20448#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list