[wp-trac] [WordPress Trac] #20897: extra_theme_headers hook no longer available
WordPress Trac
wp-trac at lists.automattic.com
Mon Jun 11 02:45:48 UTC 2012
#20897: extra_theme_headers hook no longer available
------------------------------+------------------
Reporter: greenshady | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.4
Component: Themes | Version: 3.4
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+------------------
Comment (by georgestephanis):
Minor issue with 20897.diff -- doubtful that it will ever be relevant, but
if someone filters in `URI`, `Description`, `Author`, or `AuthorURI` to
`extra_theme_headers` then we'd override the values previously set.
`array_merge()` as used in the initial patch avoids that by having the
previously defined `$theme->display()` versions trump the `$theme->get()`
versions.
Also, the current version of the function has `'AuthorName' =>
$theme->display('Author', false, false),` on line 3114 -- `->display()`
with two false params is functionally the same as `->get()` -- may be
simpler to use that instead?
20897.2.diff attached with these ideas worked out.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20897#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list