[wp-trac] [WordPress Trac] #19196: PHP notices hidden under admin bar

WordPress Trac wp-trac at lists.automattic.com
Thu Jun 7 18:14:38 UTC 2012


#19196: PHP notices hidden under admin bar
------------------------------+-----------------------
 Reporter:  sergiovieira      |       Owner:  nacin
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  3.4
Component:  Toolbar           |     Version:  3.2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by nacin):

 As [attachment:19196.3.patch] seems to work everywhere that matters, I can
 get behind it.

 We should probably call it something like _admin_bar_admin_bump_cb(), and
 we can bury it in wp-admin/includes/template.php to prevent a theme from
 trying to use it.

 An alternative, and probably a bit cleaner, would be to use a class on the
 html element itself, with is_admin_bar_showing() via
 _wp_admin_html_begin().

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19196#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list