[wp-trac] [WordPress Trac] #20871: Removing header image does not remove header_image_data theme mod

WordPress Trac wp-trac at lists.automattic.com
Thu Jun 7 11:06:07 UTC 2012


#20871: Removing header image does not remove header_image_data theme mod
--------------------------+-----------------------------
 Reporter:  kovshenin     |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Themes        |    Version:  3.4
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 When hitting Remove Header Image in Appearance > Header, the header image
 mod is set to `remove-header` which causes `get_header_image` to return
 nothing, however, the value set for the `header_image_data` theme mod
 remains, so `get_custom_header()->url` will always show the last chosen
 header image, even if it has been removed.

 This gets even nastier with flex width and height headers. When removing
 a header image, `get_custom_header()->height` will show the removed image
 height, and not the default theme mod height as (I) expected.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20871>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list