[wp-trac] [WordPress Trac] #20852: Theme Customizer: check for existence and allowed usage of previewed theme

WordPress Trac wp-trac at lists.automattic.com
Wed Jun 6 19:22:38 UTC 2012


#20852: Theme Customizer: check for existence and allowed usage of previewed theme
------------------------------------+------------------
 Reporter:  lancewillett            |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.4
Component:  Appearance              |     Version:
 Severity:  blocker                 |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by nacin):

 [attachment:20852.3.diff]

 Big things:
  * Blocks non-existent or non-allowed themes from being customized, unless
 the non-allowed theme is the active theme.
  * Fully supports a user having edit_theme_options XOR switch_themes (in
 both directions).

 General changelog:
  * moves manager->theme setup from start_previewing_theme() earlier to
 setup_theme()
  * removes the `$_REQUEST['customize']` check from the manager. I
 originally moved it to the top of the constructor to fire it earlier, but
 as the check already occurs when core instantiates it in
 _wp_customize_include(), we don't need it.
  * Prevents the loader from dealing with customize-support body classes.
 If you want these, you must use wp_customize_support_script(). This is
 necessary to allow us to conditionally call wp_customize_support_script()
 (such as a cap check) without the Loader then overriding our decision.
  * Clarifies URL arguments for deletion/activation and makes customizer
 nonces theme-specific

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20852#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list