[wp-trac] [WordPress Trac] #19549: Please remove X-Mailer from class-phpmailer

WordPress Trac wp-trac at lists.automattic.com
Sat Jun 2 13:32:25 UTC 2012


#19549: Please remove X-Mailer from class-phpmailer
-------------------------------------------------+-------------------------
 Reporter:  jwz                                  |       Owner:  westi
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  External Libraries                   |  Release
 Severity:  minor                                |     Version:  3.3
 Keywords:  has-patch commit 3.5-early 2nd-      |  Resolution:
  opinion                                        |
-------------------------------------------------+-------------------------

Comment (by clearsite):

 Replying to [comment:18 MattyRob]:
 > There is already have a slight issue that crops up periodically due to
 naming conventions. PHPMailer uses periods in it's file naming.
 (class.phpmailer.php and class.smtp.php) whereas WordPress uses hyphens
 (class-phpmailer.php and class-smtp.php).
 >
 > The issue arises because the class.phpmailer.php file includes the
 class.smtp.php file so when we rename them for WordPress we have to
 remember to make that same filename change within the file.

 There is a trivial way to never have to change the filenames again, but...
 it will create some clutter;
 Just create class-phpmailer.php and have it read "require_once
 'class.phpmailer.php'; "

 Simple, but not very elegant and certainly off-topic :P

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19549#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list