[wp-trac] [WordPress Trac] #21240: Ability to "Turn On" Native custom columns for registered custom taxonomies

WordPress Trac wp-trac at lists.automattic.com
Tue Jul 31 01:45:14 UTC 2012


#21240: Ability to "Turn On" Native custom columns for registered custom taxonomies
-----------------------------------+------------------------------
 Reporter:  jtsternberg            |       Owner:
     Type:  feature request        |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Taxonomy               |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:16 scribu]:
 > In [attachment:21240.5.diff], aren't these lines redundant:

 Currently the category column says "Uncategorized" if there's no
 categories: [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/class-
 wp-posts-list-table.php#L613 [[BR]]

 But it could say "No Categories" as well. Removed from
 [attachment:21240.6.diff] for consistency.

 > You always end up with 'categories' and 'tags', even though they might
 not be desired.

 Thanks, fixed in [attachment:21240.6.diff].

 Not sure if those `empty( $post_type )` checks in lines 274 and 279
 (introduced in [12702]) are still needed. With WP_Screen, is it possible
 to have an empty `$post_type` there?

 > My suggestion would be to transform the taxonomy names into the desired
 column names later, right before rendering.

 My concern was that a plugin or custom code might rely on `categories` or
 `tags` array key when hooking to the `manage_posts_columns` filter.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21240#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list