[wp-trac] [WordPress Trac] #21240: Ability to "Turn On" Native custom columns for registered custom taxonomies

WordPress Trac wp-trac at lists.automattic.com
Tue Jul 31 00:22:45 UTC 2012


#21240: Ability to "Turn On" Native custom columns for registered custom taxonomies
-----------------------------------+------------------------------
 Reporter:  jtsternberg            |       Owner:
     Type:  feature request        |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Taxonomy               |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------------------

Comment (by SergeyBiryukov):

 [attachment:21240.5.diff] is another take.

 * As far as I can see, there's no need for `no_items` label to be based on
 `menu_name` (this wouldn't be localizable). It can fall back to "No Tags"
 / "No Categories", like the other labels.
 * We should probably keep the existing `$posts_columns` keys and CSS
 classes for categories and tags for backwards compatibility.
 * A separate `taxonomy_column()` method doesn't seem necessary. We could
 just combine the cases in `single_row()`.
 * I think the taxonomy columns should be added before the comments and
 date columns.
 * `$posts_columns` filters should be applied after the taxonomy columns
 are added, not before.
 * `__( $taxonomy_object->label )` is not localizable.
 * `taxonomy_column_header` filter doesn't seem necessary, we can add it
 later if needed.
 * `taxonomy_column_args` filter doesn't seem necessary as well.
 * Some minor edits as per the coding standards.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21240#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list