[wp-trac] [WordPress Trac] #21270: Use update_blog_option() when enabling/disabling themes per site in Multisite

WordPress Trac wp-trac at lists.automattic.com
Tue Jul 31 00:22:21 UTC 2012


#21270: Use update_blog_option() when enabling/disabling themes per site in
Multisite
--------------------------+---------------------
 Reporter:  jeremyfelt    |       Owner:  ryan
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  3.5
Component:  Cache         |     Version:
 Severity:  minor         |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by evansolomon):

 The logical comparisons for `$id` and `get_current_blog_id()` would make
 more sense to me in the opposite order (function then variable).  That
 would be what
 [http://codex.wordpress.org/WordPress_Coding_Standards#Yoda_Conditions
 Yoda suggests], but (more importantly I think) it would also make those
 lines easier to distinguish from the preceding lines that set `$id =
 get_current_blog_id()`.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21270#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list