[wp-trac] [WordPress Trac] #14191: The test() function of the cookie class does not allow session cookies

WordPress Trac wp-trac at lists.automattic.com
Wed Jul 18 19:01:04 UTC 2012


#14191: The test() function of the cookie class does not allow session cookies
-------------------------------------+---------------------
 Reporter:  mailnew2ster             |       Owner:  dd32
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  3.5
Component:  HTTP                     |     Version:  3.0
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------

Comment (by mailnew2ster):

 > While the first chunk of diff is nice to "clean up" the existing code,
 there's some bugs that need fixing which would be harder with the cleanup.

 It's not only a "nice clean up".
 I quote my first comment:

 > Patch also improves the "new cookie from array" code, by making it
 cleaner and allowing unknown values such as httponly (like the "new cookie
 from string" code does).

 It improves the function, making it:
 1. Accept values different than '''name''', '''value''', '''path''',
 '''domain''' and '''expires''' (e.g. '''httponly''').
 2. Case-insensitive (e.g. accept '''name''', '''Name''', or '''NAME''').

 I understand it's unrelated to the current ticket title, I just wanted to
 clarify the purpose of my change.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14191#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list