[wp-trac] [WordPress Trac] #15004: Missing index on signups table
WordPress Trac
wp-trac at lists.automattic.com
Mon Jul 9 19:39:15 UTC 2012
#15004: Missing index on signups table
--------------------------+------------------
Reporter: barry | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.5
Component: Database | Version:
Severity: normal | Resolution:
Keywords: commit |
--------------------------+------------------
Changes (by nacin):
* milestone: Future Release => 3.5
Comment:
{{{
// Upgrade global tables only for the main site. Don't upgrade at all if
DO_NOT_UPGRADE_GLOBAL_TABLES is defined.
if ( in_array( $table, $global_tables ) && ( !is_main_site() || defined(
'DO_NOT_UPGRADE_GLOBAL_TABLES' ) ) )
continue;
}}}
So, dbDelta() is already aware that we should avoid upgrading global
tables except when operating on the main site (and the danger flag isn't
set). It also looks like make_db_current_silent() will trigger an upgrade
for wp_get_db_schema( 'all' ), which includes global tables. Haven't
tested, but it appears schema changes to global tables will now get picked
up just fine. All we'd need is a refresh of [attachment:15004.diff] and a
DB version bump.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15004#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list