[wp-trac] [WordPress Trac] #20220: add test to see if sunrise === on in ms-settings

WordPress Trac wp-trac at lists.automattic.com
Mon Jul 9 19:31:03 UTC 2012


#20220: add test to see if sunrise === on in ms-settings
----------------------------------------+-----------------------------
 Reporter:  sboisvert                   |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  Multisite                   |     Version:  3.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch commit 3.5-early  |
----------------------------------------+-----------------------------

Comment (by nacin):

 The 'SUNRISE' constant is one of those constants that, as long as it is
 defined in any way, triggers is_multisite() to return true. I don't find
 this to be a deal-breaker as to whether we assert truthiness before
 deciding whether to load sunrise.php, but it's nice to be consistent and
 at least understand what is going on.

 The good thing is, SUNRISE never got the ridiculous "off" and "on"
 treatment given to VHOST. Setting it to "off" did not appear to have an
 effect in MU. So this change should be backwards compatible in a sane way,
 and seems sensible enough.

 But I must ask, if you're going to disable sunrise for certain requests,
 why not just not define it?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20220#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list