[wp-trac] [WordPress Trac] #16118: Support for wp_enqueue_style with negative conditional comments
WordPress Trac
wp-trac at lists.automattic.com
Fri Jul 6 06:48:03 UTC 2012
#16118: Support for wp_enqueue_style with negative conditional comments
-------------------------------------------------+-------------------------
Reporter: sayontan | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: General | Release
Severity: normal | Version: 3.0.4
Keywords: has-patch needs-testing dev- | Resolution:
feedback |
-------------------------------------------------+-------------------------
Comment (by Umbercode):
I had some time so I thougth some more on this "problem". As I see it we
have the following possibilities:
- !IE
- (!IE)
- !IE x (where x is a version number)
- (!IE x)
- !IEMobile
- (!IEMobile)
- !IEy (where y is any string that microsoft in the future might add)
So short of a regex I think we just need to decide which one triggers the
requested behaviour.
Since !IE x and !IEMobile can mean just targeting any IE or IE derivative
we can safely assume that we want this behaviour only on !IE or (!IE), if
needed we can implicitly add it (e.g. if we also want to add all non-IE
browsers to <!--[if !IE 7]>--> we can "force" this by using <!--[if (!IE
7) | (!IE)]>-->
As such I propose we designate (!IE) as the trigger, this eliminates the
possibility for false positives like !IE 8, !IEMobile, !IE4 etc.
I attached a new patch for this.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16118#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list