[wp-trac] [WordPress Trac] #13961: search query_vars bug when using search base

[WordPress Trac]

#13961: search query_vars bug when using search base
---------------------------------+--------------------------
 Reporter:  shidouhikari         |       Owner:  markjaquith
     Type:  defect (bug)         |      Status:  reopened
 Priority:  normal               |   Milestone:  3.5
Component:  Query                |     Version:  3.0
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 3.5-early  |
---------------------------------+--------------------------

Comment (by nacin):

 Replying to [comment:28 markjaquith]:
 > Replying to [comment:27 nacin]:
 > > Should this be $this->is_main_query()? Or should we just always
 decode?
 >
 > If someone is manually doing a new WP_Query, I don't think we want to
 decode.

 Sure. But right now this will always fire on new WP_Query, unless
 query_posts() was used, as is_main_query() will just return true. This
 needs to be $this->is_main_query().

 Kinda want to deprecate the is_main_query() function and leave just the
 method. It's confusing.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13961#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software