[wp-trac] [WordPress Trac] #14207: streams.php, POMO_FileReader $length parameter of fread

WordPress Trac wp-trac at lists.automattic.com
Sun Jan 29 23:08:41 UTC 2012


#14207: streams.php, POMO_FileReader $length parameter of fread
-----------------------------------------+-----------------------------
 Reporter:  bueltge                      |       Owner:  nbachiyski
     Type:  defect (bug)                 |      Status:  assigned
 Priority:  normal                       |   Milestone:  Future Release
Component:  I18N                         |     Version:  3.0
 Severity:  major                        |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch => has-patch reporter-feedback


Comment:

 `read()` method is only called for an arbitrary number of bytes in lines
 160 and 169 of `mo.php`: [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.3.1/wp-
 includes/pomo/mo.php#L160

 [attachment:14207.2.patch] makes sure the values passed to `read()` are
 not zero.

 I'm still not sure what are we trying to fix here though. I've checked a
 localized install without Internet access with `WP_DEBUG` on and didn't
 see any warnings.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14207#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list