[wp-trac] [WordPress Trac] #19601: Support localized defaults for options, dashboard widgets, etc.
WordPress Trac
wp-trac at lists.automattic.com
Sun Jan 29 17:37:38 UTC 2012
#19601: Support localized defaults for options, dashboard widgets, etc.
----------------------------+------------------
Reporter: nacin | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.4
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: |
----------------------------+------------------
Comment (by nacin):
[attachment:19601.diff] attempts to localize gmt_offset and
timezone_string.
Unfortunately, our changes back in 2.9 to always set UTC means that
`date('Z') / 3600` will always return 0. (Some commentary in #10940 and
elsewhere.) In fairness, server time is not particularly effective for
determining timezones, so I don't think it is worth a hack to store the
initial timezone string before loading the bootstrap, as I first
considered. (This isn't the only dead code in upgrade.php that tries in
vain to get the server's offset, only to do math with a bunch of zeroes.)
We should go forward with this patch, and try to work in client detection
of timezones to benefit all users, such as #10660.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19601#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list