[wp-trac] [WordPress Trac] #19905: Filtering the edit-comments.php screen results in incorrect Pending count

WordPress Trac wp-trac at lists.automattic.com
Thu Jan 26 23:44:20 UTC 2012


#19905: Filtering the edit-comments.php screen results in incorrect Pending count
--------------------------+------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Comments      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------
Description changed by nacin:

Old description:

> 1. Go to edit-comments.php and view the comments for a single post (click
> the bubble, or do ?p=1234).
>
>  2. Note the Pending comment number, say, 4, which would be lower than
> the total number of pending comments, say, 10.
>
>  3. Trash an unapproved (pending) comment.
>
>  4, expected: The pending comment number in the toolbar and admin menu
> should reduce to 9. The Pending number on edit-comments.php should reduce
> to three.
>
> Actual: All three numbers are set to 9.
>
> Tracked it down with ryan to delAfter getting the pending count from
> $('span.pending-count').eq(0). Three elements match span.pending-count --
> the admin menu, Pending (0), and the toolbar, in that order. eq(0) means
> it pulls from the global pending #, from the admin menu.
>
> If you change it to eq(1), then the toolbar and admin menu are both
> updated to 3. All three values are linked no matter what. Normally, this
> is proper. But in the case of a filtered edit-comments.php, they must not
> be.

New description:

 1. Go to edit-comments.php and view the comments for a single post (click
 the bubble, or do ?p=1234).

  2. Note the Pending comment number, say, 4, which would be lower than the
 total number of pending comments, say, 10.

  3. Trash an unapproved (pending) comment.

  4. (Expected) The pending comment number in the toolbar and admin menu
 should reduce to 9. The Pending number on edit-comments.php should reduce
 to three.

 Actual: All three numbers are set to 9.

 Tracked it down with ryan to delAfter getting the pending count from
 $('span.pending-count').eq(0). Three elements match span.pending-count --
 the admin menu, Pending (0), and the toolbar, in that order. eq(0) means
 it pulls from the global pending #, from the admin menu.

 If you change it to eq(1), then the toolbar and admin menu are both
 updated to 3. All three values are linked no matter what. Normally, this
 is proper. But in the case of a filtered edit-comments.php, they must not
 be.

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19905#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list