[wp-trac] [WordPress Trac] #17242: Themes: Allow flexible sizes for custom header uploads

[WordPress Trac]

#17242: Themes: Allow flexible sizes for custom header uploads
----------------------------+------------------
 Reporter:  lancewillett    |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.4
Component:  Themes          |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  dev-feedback    |
----------------------------+------------------

Comment (by aaroncampbell):

 Ok, there are two issues that I'm concerned about and want feedback on:
 1. It seems like we should add a minimum width requirement for uploaded
 images so that we don't scale them up.  You can currently upload a 125x125
 image, go through the JS crop, and get a horribly ugly header image that
 has stretched it to 7x it's original width. If we add flex width it won't
 matter for themes that support that, but it would still affect all the
 others.  Talked to both [https://irclogs.wordpress.org/chanlog.php?channel
 =wordpress-dev&day=2012-01-23&sort=asc#m356139 Rboren and Koop in irc] and
 they both agreed.
 1. Additionally, the issue with [comment:32 getting the header image
 dimensions] is nagging at me.  For the admin preview we could change to
 using an image tag instead of a background image, but the themes that
 layer site name over the top would have issues.  Additionally, as I
 pointed out above, I think it's common for a theme to need to know the
 dimensions, so I think we probably need a way to give those to them.  I
 could put the code above into a helper function of some kind (maybe even
 return an array like [http://php.net/getimagesize getimagesize()]), but I
 don't like the weight of the function and was hoping someone else had a
 brilliant solution.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17242#comment:35>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software