[wp-trac] [WordPress Trac] #17242: Themes: Allow flexible sizes for custom header uploads

WordPress Trac wp-trac at lists.automattic.com
Mon Jan 23 18:51:00 UTC 2012


#17242: Themes: Allow flexible sizes for custom header uploads
----------------------------+------------------
 Reporter:  lancewillett    |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.4
Component:  Themes          |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  dev-feedback    |
----------------------------+------------------

Comment (by aaroncampbell):

 In the last dev chat ([https://irclogs.wordpress.org/chanlog.php?channel
 =wordpress-dev&day=2012-01-18&sort=asc#m354756 Starting here on
 01/18/2012]) we decided to handle flex height and see how that works, with
 the possibility of adding flex height on the next two week cycle.

 The new patch does that.  It also updates the imgAreaSelect jQuery plugin,
 which wasn't strictly necessary, but seemed to make sense.

 Basically a theme can add support for custom headers with flex width like
 this:
 {{{
 add_theme_support( 'custom-header', array( 'flex-height' => true,
 'suggested-height' => 300 ) );
 }}}

 It also seems like we should add a minimum width requirement for uploaded
 images so that we don't scale them up (you can currently upload a 125x125
 image, go through the JS crop, and get a horribly ugly header image that
 has stretched it to 7x it's original width).  If we add flex width it
 won't matter for themes that support that, but it would still affect all
 the others.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17242#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list