[wp-trac] [WordPress Trac] #19820: More post slug cleaning

WordPress Trac wp-trac at lists.automattic.com
Fri Jan 13 23:59:28 UTC 2012


#19820: More post slug cleaning
---------------------------+--------------------
 Reporter:  honza.skypala  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.4
Component:  Formatting     |     Version:  3.3.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+--------------------
Changes (by kurtpayne):

 * cc: kpayne@… (added)
 * keywords:  has-patch needs-unit-tests => has-patch


Comment:

 [[attachment:19820.2.patch]] fixes this test case:

 {{{
 $this->assertEquals("one-two", sanitize_title_with_dashes("One & Two;",
 '', 'save'));
 }}}

 Output was:

 {{{
 There was 1 failure:

 1) TestSanitizeTitleWithDashes::test_strips_entities
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'one-two'
 +'one'
 }}}

 This change is unrelated to SergeyBiryukov's patch, but is related to the
 request for unit tests.

 SergeyBiryukov's patch looks good.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19820#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list