[wp-trac] [WordPress Trac] #17242: Themes: Allow flexible sizes for custom header uploads

[WordPress Trac]

#17242: Themes: Allow flexible sizes for custom header uploads
--------------------------+------------------
 Reporter:  lancewillett  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Themes        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------
Changes (by aaroncampbell):

 * keywords:  has-patch dev-feedback => dev-feedback


Comment:

 I think our first step needs to be deciding what we want to support, then
 deciding how that will work for theme developers.

 1. I think it makes sense to support flexible widths '''and''' heights.
 Height is obvious, but even in fixed width themes allowing the header to
 extend past the content can help eliminate the boxy feel.
 1. We need to decide if we're going to allow for min and/or max.  Here are
 the possible options:
  a. Support flexible sizes for width and/or height.  This would let a
 theme author say any of the following:
   1. Header should be 1000px wide and 300px high
   1. Header should be 1000px wide and any height
   1. Header can be any width and 300px high
   1. Header can be any size
  a. Support minimums.  This would add the ability to say that the header
 should be '''at least''' 1000px wide or '''at least''' 40px high.  This
 seems to make sense for widths more than heights.
  a. Support maximums.  This would add the ability to say that the header
 should be '''no more''' than 1000px wide or '''no more''' than 500px high.
 This seems to make more sense for heights than widths.
  a. Support both min and max.  This would let the theme say that the
 header should be '''at least''' 1000px wide and '''no more''' than 500px
 high.
 1. Once we decide the above we'll need to decide what theme authors need
 to do to add support.  It seems obvious to `add_theme_support()` but
 depending on whether we support min and/or max we'll have to decide on the
 exact wording/syntax.

 My original stance was that it would be really nice to allow for the
 min/max options.  However, the more I think about it the more I realize
 this really encourages theme authors to take control away from users.
 While I look at a 1000px wide design and think a header should be at least
 that wide, what's the big deal if a user wants a 500px wide header?  It
 seems like they should be able to make their site look however they want.
 I think option 'a' that just allows fixed or flexible "helps you make
 things look the way you want" more than the others.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17242#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software