[wp-trac] [WordPress Trac] #19808: PHPMailer -> MsgHTML single quote bug

[WordPress Trac]

#19808: PHPMailer -> MsgHTML single quote bug
--------------------------+------------------------------
 Reporter:  WPsites       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Mail          |     Version:  3.3.1
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by kurtpayne):

 * cc: kpayne@… (added)


Comment:

 Your code would also match: `<img src=|image.png| />`

 The character group (square brackets) already means "any of these
 characters."  You would only use the pipe in a parentheses group.  For
 example: `[\"']` is equivalent to `(\"|')`

 Have you tested without the pipe?

 Is it a problem that this could would also match imbalanced quotes?  This
 matches:

 `<img src='image.png" />` and `<img src="image.png' />`

 I would, generally, say no, since the images get re-written using correct
 markup.  Others may want to weigh in on this.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19808#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software