[wp-trac] [WordPress Trac] #17902: You guys should add a "Plugin Details" pop-up link to installed plugins.

[WordPress Trac]

#17902: You guys should add a "Plugin Details" pop-up link to installed plugins.
-------------------------------------+------------------------------
 Reporter:  trusktr                  |       Owner:  chsxf
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Plugins                  |     Version:  3.1.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by kurtpayne):

 The patch on this is broken into two parts.  [[attachment:markdown.php]]
 is the latest version of Markdown Extra.  This should be placed in wp-
 admin/includes.  [[attachment:17902.patch]] are the !WordPress
 modifications.

 Let me explain real quick why this patch is big:

 class-wp-plugin-readme-parser.php:
 This parses a plugin's readme.txt file into a data structure (associative
 array).

 The readme.txt format is not stock markdown.  There is a !WordPress spin
 to it, to enhance any backtick code sections.  I opted not to use the
 [http://code.svn.wordpress.org/plugin-readme-parser/parse-readme.php
 existing parser] because it had a few references to bbPress and was
 calling deprecated functions (e.g. clean_url).

 wp-admin/includes/plugin-install.php:
 This gets the plugin info based on a slug and renders the page.  The
 changes here should look really similar to `install_plugin_information()`.

 The `local_plugin_api()` function will combine the plugin header with the
 readme.txt file to generate an object similar to the remote API.  The
 readme.txt file is missing some information that is contained in the
 plugin header (like the author's name and plugin home page).  Also, if the
 readme.txt file is not available (in the case of Hello Dolly) then the
 only information available will be in the plugin header.

 class-wp-plugins-list-table.php:
 Insert the "Details" link into the plugins table

 plugin-install.php:
 Ensure that the plugin-readme page is an iframe and not thickbox

 colors-class.dev.css, colors-fresh.dev.css, wp-admin.dev.css, wp-admin-
 rtl.dev.css
 The `#plugin-information` and `#plugin-information-header` containers were
 styled in a lot of places.  The three options I saw were
 1. Create a new tab and duplicate the existing CSS rules
 2. Genericize the rules to classes and edit the existing markup (and risk
 a regression)
 3. Hijack `install_plugin_information()` with {{{if ($local) {...} else
 {...}}}} logic.

 The first option seemed the cleanest to me, but I welcome feedback.

 Per discussion, no screenshots at this point.  The entire section is
 removed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17902#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software