[wp-trac] [WordPress Trac] #19789: Media options screen - misunderstanding

[WordPress Trac]

#19789: Media options screen - misunderstanding
--------------------------+-----------------------------
 Reporter:  pavelevap     |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  3.3.1
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 There is following code in options-media.php:

 {{{
 if ( ! empty( $content_width ) )
         $media_options_help .= ' ' . __( 'If you do not set the maximum
 embed size, it will be automatically sized to fit into your content area.'
 );
 }}}

 and

 {{{
 if ( !empty($content_width) ) echo '<br />' . __("If the width value is
 left blank, embeds will default to the max width of your theme.");
 }}}


 But even if maximum embed size is set (width and height) or not, we are
 checking $content_width which can be set by theme (for example Twenty
 Eleven) and not by Maximum embed size values on this screen.

 When Twenty Eleven is activated, these two strings are always visible and
 there is no way how to change width, even if these strings talk about it.

 When any other theme is activated (without $content_width), these strings
 will be never displayed.

 I am not sure what is wrong (strings or logic), but it is misleading for
 users, I guess...

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19789>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software