[wp-trac] [WordPress Trac] #18749: Remove "the hackiest hack that ever did hack" from add_user()

[WordPress Trac]

#18749: Remove "the hackiest hack that ever did hack" from add_user()
-----------------------------------+---------------------
 Reporter:  duck_                  |       Owner:
     Type:  enhancement            |      Status:  closed
 Priority:  normal                 |   Milestone:  3.4
Component:  Users                  |     Version:
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+---------------------
Changes (by duck_):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 nacin]:
 > Grain of salt, but I prefer `! $user_id = edit_user()` to `! ( $user_id
 = edit_user() )`, the latter looks like a situation where you're trying to
 invert what's inside. The former looks like a deliberate assignment and a
 check against the value of the assignment.

 FWIW I was thinking that somebody might read `! $user_id = edit_user()` as
 "$user_id doesn't equal edit_user()", but parens removed and left as is.

 [19689]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18749#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software