[wp-trac] [WordPress Trac] #18758: Click empty admin bar to scroll to top

WordPress Trac wp-trac at lists.automattic.com
Thu Jan 5 16:47:36 UTC 2012


#18758: Click empty admin bar to scroll to top
---------------------------------+-----------------------
 Reporter:  TJNowell             |       Owner:  ericmann
     Type:  task (blessed)       |      Status:  assigned
 Priority:  normal               |   Milestone:  3.4
Component:  Toolbar              |     Version:  3.3
 Severity:  normal               |  Resolution:
 Keywords:  3.4-early has-patch  |
---------------------------------+-----------------------

Comment (by ericmann):

 Did some work on the patch and fixed it to work with IE7-9.  If we're not
 supporting IE7 (I missed the dev chat, so I'm not sure if we're still
 supporting that browser or not) then we can lose the `&& t.id != 'wp-
 admin-bar-top-secondary'` part of the id selector conditionals.  The patch
 will function just fine in IE8-9 without that, but it's needed for IE7
 because of the way the right-hand side of the toolbar is presented on the
 page.

 Also, the fix for IE8 is to use `document.documentElement.scrollTop` to
 get a value for `startY`.  I've added that fix as well.

 Fully tested in every browser I have access to (IE7-9, Chrome latest, FF
 latest, Safari) on Windows 7.  Works both with and without jQuery.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18758#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list