[wp-trac] [WordPress Trac] #19549: Please remove X-Mailer from class-phpmailer

[WordPress Trac]

#19549: Please remove X-Mailer from class-phpmailer
-----------------------------------+-----------------------
 Reporter:  jwz                    |       Owner:  westi
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  3.4
Component:  External Libraries     |     Version:  3.3
 Severity:  minor                  |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+-----------------------

Comment (by MattyRob):

 Replying to [comment:16 jwz]:
 > Replying to [comment:15 MattyRob]:
 > I think you're saying "there is little point to" when you mean "it would
 be slightly inconvenient to".
 >
 > You're saying "I don't want to change PHPMailer because then I'd have to
 merge the changes every time I upgrade it."  I'm glad you understand where
 I'm coming from, because that is exactly what I'm saying to you! I'm tired
 of hand-merging my changes to the WordPress distro every time I update it.
 So I reported this bug in the hopes that I'll get to stop doing that.

 I can understand and sympathise with your frustrations, there are aspects
 of WordPress that I dislike and I patch these to suit my personal
 preference with each release too.

 That said that are compelling arguments to not fork the external libraries
 if this can be avoided.

 I only help out on here giving my time for free. I earn no income from
 WordPress directly. I contribute patches when I think I can help. I'm not
 keen on taking responsibility for continually updating and checking the
 PHPMailer library to keep it both current and patched for WordPress.

 There is already have a slight issue that crops up periodically due to
 naming conventions. PHPMailer uses periods in it's file naming.
 (class.phpmailer.php and class.smtp.php) whereas WordPress uses hyphens
 (class-phpmailer.php and class-smtp.php).

 The issue arises because the class.phpmailer.php file includes the
 class.smtp.php file so when we rename them for WordPress we have to
 remember to make that same filename change within the file.

 Making additional changes in the hope that these are also made upstream
 but with no guarantee will generate work for someone. I think the best
 solution for WordPress is to patch wp_mail() as best we can to allow
 X-Priority and X-Mailer to be altered by plugins and to report (as has
 been done) this issue upstream to the authors of PHPMailer and hope they
 make the changes we would like.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19549#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software