[wp-trac] [WordPress Trac] #19910: Appearance Improvements: Theme Customization Frame

[WordPress Trac]

#19910: Appearance Improvements: Theme Customization Frame
----------------------------+--------------------------
 Reporter:  koopersmith     |       Owner:  koopersmith
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  3.4
Component:  Themes          |     Version:  3.3.1
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+--------------------------

Comment (by cais):

 Replying to [comment:25 koopersmith]:
 > Replying to [comment:24 cais]:
 > > This may be more observation and be a result of coder error but I
 found the following to cause the Customization > Navigation to not produce
 the results you would expect...
 >
 > I'll look into this. If I'm reading this correctly, is the only
 difference that the nav menu registration is attached to `init` instead of
 `after_setup_theme`?

 No, not quite ... here is a link to the actual functions.php file for Desk
 Mess Mirrored. It may be easier to see the code in its unadulterated form:
 https://github.com/Cais/desk-mess-mirrored/blob/master/functions.php

 Starting at line 248 is the `desk_mess_mirrored_setup` function that is
 used with the 'after_theme_setup' hook, while inside that function
 starting at line 365 is the 'register_nav_menu' function call which uses
 the 'init' hook ...

 ... the more I look at this the more I think using the 'init' hook this
 way is not correct and could just be awkward code catching up to me.
 Although I have not seen any issues with this "menu code" since I
 implemented it back around WP 3.1.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19910#comment:27>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software