[wp-trac] [WordPress Trac] #18311: Support HTML in image captions.
WordPress Trac
wp-trac at lists.automattic.com
Tue Feb 28 22:50:26 UTC 2012
#18311: Support HTML in image captions.
-----------------------------------+-----------------------
Reporter: prettyboymp | Owner: sushkov
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 3.4
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: ux-feedback has-patch |
-----------------------------------+-----------------------
Comment (by jeremyclarke):
Hey guys it's come a long way!
'''TRUNK VERSION'''
The links work and I'm finding they persist well when switching back and
forth between HTML and Visual. It's great that the caption can be edited
in the Visual editor and in the popup.
One thing I noticed is it strips out any use of {{{title=}}} in links. Is
that intentional/desirable? Link titles are important for accessibility as
well as for SEO, if there's one attribute we should keep other than href
it's probably title.
It's nice that if you type double quotes for caption links in the HTML
editor then switching to VIsual editor makes them single quotes, but is
there a way we could also do the same thing for people who only use the
HTML editor? Right now saving the posts keeps the broken double-quotes-
inside-double-quotes format and previewing it just makes the caption
dissapear. It would be nice if people were protected from themselves even
if they only use the HTML editor.
We aren't planning to stick with the "Add link" UI that's in trunk right
now are we? I'm a bit confused but it sounds like Sushkov's patches to add
quicktags is the right way to go.
'''PATCH VERSION'''
Unfortunately I can't seem to get the 18311_qtags_ui.4.diff patch to work.
It patches successfully, but the result is very broken. In the uploader
popup I can see a loose textarea at the bottom of the popup with the
quicktags above it but looking unstyled.
Is there another patch from above that I need to get it working with
trunk?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18311#comment:56>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list