[wp-trac] [WordPress Trac] #13774: Theme installer should support child themes
WordPress Trac
wp-trac at lists.automattic.com
Tue Feb 28 18:21:16 UTC 2012
#13774: Theme installer should support child themes
-----------------------------------------------+-----------------------
Reporter: westi | Owner: dd32
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 3.4
Component: Upgrade/Install | Version: 3.0
Severity: normal | Resolution:
Keywords: has-patch 3.4-early needs-testing |
-----------------------------------------------+-----------------------
Comment (by Otto42):
Testing it now.
Notes:
- Check the 13774.3.diff before commit. There's two sections of debug code
that needs to be removed first. Both are marked with TODO's.
- Works for pre-existing parent themes (mazeld depends on twenty-ten):
{{{
Downloading install package from
http://wordpress.org/extend/themes/download/mazeld.1.0.zip…
Unpacking the package…
Installing the theme…
This theme requires a parent theme, Checking if twentyten is installed…
The Parent theme, Twenty Ten 1.3, is currently installed.
Successfully installed the theme Mazeld 1.0.
}}}
Works for children that don't have a parent installed (multi depends on
desk-mess-mirrored):
{{{
Downloading install package from
http://wordpress.org/extend/themes/download/multi.1.8.3.zip…
Unpacking the package…
Installing the theme…
This theme requires a parent theme, Checking if desk-mess-mirrored is
installed…
Preparing to install Desk Mess Mirrored 2.0.1…
Downloading install package from
http://wordpress.org/extend/themes/download/desk-mess-mirrored.2.0.1.zip…
Unpacking the package…
Installing the theme…
Successfully installed the parent theme Desk Mess Mirrored 2.0.1.
Successfully installed the theme Multi 1.8.3.
}}}
- Works for both cases in direct mode.
- Works for both cases when forcing FTP mode (ftpsockets). Note, tested on
localhost, so PHP timeouts not a problem in this case. But nothing much
that can be done about that anyway.
- FTP Filesystem finder works correctly to find the right directories on a
multi-single-site install in FTP mode. Tested with 8 subdirectory WP
installs on localhost and the FTP directory pointing at the htdocs root
(so it can see them all).
Looks good to me. Remove the debug lines and should be good to go. UI
details can be adjusted later if needed.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/13774#comment:31>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list