[wp-trac] [WordPress Trac] #20103: Rewrite get_themes() and other enemies of sanity

[WordPress Trac]

#20103: Rewrite get_themes() and other enemies of sanity
--------------------------+------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Themes        |     Version:  1.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by GaryJ):

 * cc: gary@… (added)


Comment:

 On the naming issue, could we fix the non-existent word "stylesheet"? It
 has, and always was two words, as per the CSS abbreviation, and the names
 on the corresponding W3C documents.

 After a very quick look through the patch, I see `$stylesheet` only as a
 private property, or as the argument names / variables inside functions,
 so they could be switched to `$style_sheet` without fuss.

 Any standalone function like `get_stylesheet()` that remains after scribu
 has had his suggestion of renaming them, could stay as it was, but the
 methods introduced in the class could be renamed as `get_style_sheet()`.
 Obviously `Stylesheet` array keys would stay as they are too, unless you
 wanted to allow both versions.

 I suspect the suggestion will be disregarded on grounds of introducing
 inconsistency, but since you're re-writing a hefty chunk of the internals,
 now is the most opportune moment to suggest improvements to the internals
 to match the naming conventions in the coding standards.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20103#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software