[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

WordPress Trac wp-trac at lists.automattic.com
Mon Feb 27 21:20:07 UTC 2012


#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by azaozz):

 Replying to [comment:93 TomAuger]:
 > Are you suggesting we only allow upload of 16 x 16 or 32 x 32 sized
 images, and don't allow for crop or resize?

 Not exactly. Best probably would be to expect properly sized images. If
 the user uploads something above 32x32, it can be cropped and resized
 automatically and saved as .png (and .ico if possible). We need to allow
 uploading of favicons and properly include/link them, not make a tool for
 creating tham :)

 > I can see your arguments for this approach. However, all the images
 (photographic or otherwise) that I have used during the testing have
 turned out remarkably well...

 Yes, many would turn well but many would fail too. It would be better if
 the user knows what the image looks like before uploading.

 > I don't mind the idea of adding a "help" icon that would provide tips,
 or some contextual help on the General settings page...

 Yes, I meant a tab in the contextual help, probably with a short sentence
 under the "Upload" button that will send the user there. We won't need to
 add a lot of text, only 1-2 sentences explaining that favicons are very
 small images and should be generated by software or on particular
 websites.

 > I believe that for the 80% we give them the ability to upload anything.

 Right, but also tell them what a favicon is and how they can make a good
 looking one.

 > And for the 20%, let's make sure that if we do get an icon in 16x16 or
 32x32, or if it's already in ico format, it doesn't get interpolated or
 otherwise mutilated.

 Agree. If an .ico image is uploaded or if the image is already 32x32 we
 shouldn't touch it at all (don't think we can touch .ico in GD anyways).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:94>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list